Debian Patches

Status for ethtool/1:6.15-3

Patch Description Author Forwarded Bugs Origin Last update
netlink-fix-missing-headers-in-text-output.patch netlink: fix missing headers in text output
The commit under fixes added a NULL-check which prevents us from
printing text headers. Conversions to add JSON support often use:

print_string(PRINT_FP, NULL, "some text:\n", NULL);

to print in plain text mode.

Correct output:

Channel parameters for vpn0:
Pre-set maximums:
RX: n/a
TX: n/a
Other: n/a
Combined: 1
Current hardware settings:
RX: n/a
TX: n/a
Other: n/a
Combined: 0

With the buggy patch:

Channel parameters for vpn0:
RX: n/a
TX: n/a
Other: n/a
Combined: 1
RX: n/a
TX: n/a
Other: n/a
Combined: 0
Jakub Kicinski <kuba@kernel.org> no https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit?id=b70c928661024cd07914feb49122275daab904ea 2025-07-12
netlink-fix-print_string-when-the-value-is-NULL.patch netlink: fix print_string when the value is NULL
The previous fix in commit b70c92866102 ("netlink: fix missing headers
in text output") handles the case when value is NULL by still using
`fprintf` but passing no value.

This fails if `-Werror=format-security` is passed to gcc, as is the
default in distros like Fedora.

```
json_print.c: In function 'print_string':
json_print.c:147:25: error: format not a string literal and no format arguments [-Werror=format-security]
147 | fprintf(stdout, fmt);
|
```

Use `fprintf(stdout, "%s", fmt)` instead, using the format string as the
value, since in this case we know it is just a string without format
chracters.
Michel Lind <michel@michel-slm.name> no https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit?id=41d6105250c8293eddeb5f9332434728e7da4335 2025-07-24

All known versions for source package 'ethtool'

Links