Debian Patches

Status for git-ubuntu/1.1-1

Patch Description Author Forwarded Bugs Origin Last update
Drop-unused-petname.patch Drop unused petname
The Python library `petname` is not used any more.
Benjamin Drung <benjamin.drung@canonical.com> yes 2024-07-03
man-Fix-bad-whatis-entries.patch man: Fix bad whatis entries
lintian complains about bad-whatis-entry: A manual page should start
with a NAME section, which lists the program name and a brief
description. The NAME section is used to generate a database that can be
queried by commands like apropos and whatis. You are seeing this tag
because lexgrog was unable to parse the NAME section. Listed items may
not contain any spaces. A manual page for a two-level command such as fs
listacl must look like fs_listacl so the list is read correctly.
Benjamin Drung <benjamin.drung@canonical.com> yes 2024-07-03
test-call-dch-with-vendor-Ubuntu-in-reconstruct-changelog.patch test: call dch with --vendor=Ubuntu in reconstruct-changelog
test_reconstruct_changelog fails on Debian unstable:

```
__________________________ test_reconstruct_changelog __________________________

pygit2_repo = pygit2.Repository('/tmp/tmp5ktk68oo/.git/')
monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7b447f19f2f0>

@pytest.mark.skipif(
ENTRY_POINT_TYPE is None,
reason="Entry point testing not available",
)
def test_reconstruct_changelog(pygit2_repo, monkeypatch):
'''The reconstruct-changelog endpoint should add the expected commit'''
monkeypatch.setenv('DEBFULLNAME', 'Test User')
monkeypatch.setenv('DEBEMAIL', 'test@example.com')
Repo(
commits=[
Commit(tree=SourceTree(Source()), name='root'),
Commit(
tree=SourceTree(Source(spec=SourceSpec(mutate=1))),
message=' * Test changelog entry',
name='child',
parents=[Placeholder('root')],
),
],
tags={'root': Placeholder('root'), 'child': Placeholder('child')},
).write(pygit2_repo)
pygit2_repo.checkout('refs/tags/child')
subprocess.check_call(
[get_entry_point('reconstruct-changelog'), 'HEAD^'],
cwd=pygit2_repo.workdir,
)
with open(os.path.join(pygit2_repo.workdir, 'debian/changelog'), 'r') as f:
changelog_lines = f.read().splitlines()
> assert changelog_lines[0:4] == [
'source-builder-package (1-1ubuntu1) UNRELEASED; urgency=medium',
'',
' * Test changelog entry',
'',
]
E AssertionError: assert ['source-buil...ngelog entry'] == ['source-buil...og entry', '']
E
E At index 0 diff: 'source-builder-package (1-1.1) UNRELEASED; urgency=medium' != 'source-builder-package (1-1ubuntu1) UNRELEASED; urgency=medium'
E Use -v to get more diff

gitubuntu/integration_test.py:226: AssertionError
Benjamin Drung <benjamin.drung@canonical.com> no 2024-07-03
submit-fix-setting-commitish_string.patch submit: fix setting commitish_string
pylint complains:

```
************* Module gitubuntu.submit
gitubuntu/submit.py:138:53: E0606: Possibly using variable 'commitish_string' before assignment (possibly-used-before-assignment)
```
Benjamin Drung <benjamin.drung@canonical.com> yes 2024-07-03
test-Always-set-ENTRY_POINT_DIR.patch test: Always set ENTRY_POINT_DIR
pylint complains:

```
************* Module gitubuntu.integration_test
gitubuntu/integration_test.py:77:26: E0606: Possibly using variable 'ENTRY_POINT_DIR' before assignment (possibly-used-before-assignment)
```

So always set `ENTRY_POINT_DIR` even when this variable is not used when
`ENTRY_POINT_TYPE` is `None`.
Benjamin Drung <benjamin.drung@canonical.com> yes 2024-07-03

All known versions for source package 'git-ubuntu'

Links