Debian Patches

Status for monitoring-plugins/2.4.0-3

Patch Description Author Forwarded Bugs Origin Last update
12_check_curl_add_docu [PATCH] check_curl: Documentation for --certificate, --cookie-jar
From the mere help output for -C / --certificate, I was confused about
what its two integer parameters do. Unfortunately, I also missed out on
the explaining examples later. Since I like to have basic documentation
for each flag, I tried to make the arguments as short as possible.

The other fix was one hyphen too many for the --cookie-jar option.
Alvar Penning <alvar.penning@icinga.com> no 2024-08-16
13_check_mysql_fix_variables diff --git a/plugins/check_mysql.c b/plugins/check_mysql.c
index 6a7daf11a..15ec04c04 100644
no
14_check_curl_remove_experimental_state diff --git a/plugins/check_curl.c b/plugins/check_curl.c
index e9c15e648..e25d7a79a 100644
no
15_check_curl_fix_regex [PATCH 1/3] check_curl: Fix help for state regex option
The help output of `check-curl` contained a typo,
the real option is `state-regex` and not `regex-state` as
the help suggests.
Also added the two possible options to avoid confusion.
RincewindsHat <12514511+RincewindsHat@users.noreply.github.com> no 2024-08-19
02_check_icmp_links ## 02_check_icmp_links by Jan Wagner <waja@cyconet.org>
##
## DP: Create symlinks for check_icmp to provide default values for some situations

diff -urNad nagios-plugins-1.4.14~/plugins-root/Makefile.am nagios-plugins-1.4.14/plugins-root/Makefile.am
no
03_epn no
04_lmstat_path no
10_check_curl_fix_redirects [PATCH] check_curl: fix relative redirects on non-standard port
Having a webserver respond with a relative redirect as for ex. in `Location: /path/to.html`
check_curl would use the wrong standard http/https port instead
of crafting the absolute url using the given scheme/hostname and port.

Adding a new test case for this for check_http and check_curl. check_http did
it correct already, so no fix necessary there.

before:

%>./check_curl -H 127.0.0.1 -p 50493 -f follow -u /redirect_rel -s redirected -vvv
**** HEADER ****
HTTP/1.1 302 Found
...
Location: /redirect2

...
* Seen redirect location /redirect2
** scheme: (null)
** host: (null)
** port: (null)
** path: /redirect2
Redirection to http://127.0.0.1:80/redirect2

fixed:

%>./check_curl -H 127.0.0.1 -p 50493 -f follow -u /redirect_rel -s redirected -vvv
**** HEADER ****
HTTP/1.1 302 Found
...
Location: /redirect2

...
* Seen redirect location /redirect2
** scheme: (null)
** host: (null)
** port: (null)
** path: /redirect2
Redirection to http://127.0.0.1:50493/redirect2
Sven Nierlein <sven@consol.de> no 2024-07-29
11_check_curl_raise_ssl_issue [PATCH] check_curl: raise SSL issue when --continue-after-certificate is used

This change aims to raise the worst status between the SSL check and the HTTP check.

before:
check_curl -H www.google.fr -S --continue-after-certificate --certificate 4000,4000 ; echo $?
CRITICAL - Certificate '*.google.fr' expires in 74 day(s) (Tue 22 Oct 2024 12:53:52 PM GMT +0000).
HTTP OK: HTTP/2 200 - 22807 bytes in 0.076 second response time |time=0.075516s;;;0.000000;10.000000 size=22807B;;;0;
0

after:
/usr/lib/nagios/ovh/check_curl -H www.google.fr -S --continue-after-certificate --certificate 4000,4000 ; echo $?
CRITICAL - Certificate '*.google.fr' expires in 74 day(s) (Tue 22 Oct 2024 12:53:52 PM GMT +0000).
HTTP OK: HTTP/2 200 - 22840 bytes in 0.090 second response time |time=0.090463s;;;0.000000;10.000000 size=22840B;;;0;
2
Yannick Martin <yannick.martin@ovhcloud.com> no 2024-08-09
16_check_curl_openssl_error [PATCH] fix check_curl: OpenSSL SSL_read: error:0A000126:SSL routines::unexpected eof while reading, errno 0

using check_curl on a probably embedded device responding as 'Server: GoAhead-Webs'

%> check_curl -H ... -S -vvv

> GET / HTTP/1.1
Host: ...
User-Agent: check_curl/v2.4.0 (monitoring-plugins 2.4.0, libcurl/7.76.1 OpenSSL/3.0.7 zlib/1.2.11 brotli/1.0.9 libidn2/2.3.0 libpsl/0.21.1 (+libidn2/2.3.0) libssh/0.10.4/openssl/zlib nghttp2/1.43.0)
Accept: */*
Connection: close

* Mark bundle as not supporting multiuse
* HTTP 1.0, assume close after body
< HTTP/1.0 302 Redirect
< Server: GoAhead-Webs
< Date: Tue Mar 26 17:57:16 2019
< Cache-Control: no-cache, no-store, must-revalidate,private
< Pragma: no-cache
< Expires: 0
< Content-Type: text/html
< X-Frame-Options: sameorigin
< X-XSS-Protection: 1; mode=block
< X-Content-Type-Options: nosniff
< Location: https://...
<
* OpenSSL SSL_read: error:0A000126:SSL routines::unexpected eof while reading, errno 0
* Closing connection 0

reading the discussion on https://github.com/openssl/openssl/discussions/22690 suggest to set the option SSL_OP_IGNORE_UNEXPECTED_EOF
which makes check_curl behave like check_http at this point.
Since this is a rather new flag, fencing it in ifdefs.
And since there can only be one ssl ctx function, we need to move both tasks into one function.
Sven Nierlein <sven@consol.de> no 2024-10-09
17_check_fping_dontfrag_random [PATCH] Add dontfrag/random for fping
Support the dont fragment and randomise packet data options for check_fping
William <william@blackhats.net.au> no 2024-11-06
18_check_curl_fix_TLS_notes [PATCH] check_curl: update TLS notification notes =?UTF-8?q?Lorenz=20K=C3=A4stle?= no 2024-11-27
19_check_curl_cookie_handling [PATCH] check_curl: enable internal cookie handling
This enables us to enable curl cookie engine by specifying an empty
filename as the cookie jar file.

This works, since curl's CURLOPT_COOKIEFILE option allows passing an
empty string as filename, which it interprets as a request to enable the
cookie processing. But since CURLOPT_COOKIEJAR would now attempt to
write to a file named by an empty filename, it would break again (or at
least produce a warning in verbose output).

Overall this is allows to handle checking URLs with cookie based
sessions without persisting the cookies to disk, by using the
curl-internal redirect following.
=?UTF-8?q?Andre=20Kl=C3=A4rner?= <kandre@ak-online.be> no 2024-11-29
20_check_icmp_fix_rtmin [PATCH] check_icmp: set rtmin initially =?UTF-8?q?Lorenz=20K=C3=A4stle?= no 2024-11-27
21_check_http_state_regex [PATCH] check_http: fix documentation for --state-regex Andreas Baumann <mail@andreasbaumann.cc> no 2024-12-27
22_check_by_ssh_missing_options [PATCH] check_by_ssh: Remove warning/critical from help =?UTF-8?q?Lorenz=20K=C3=A4stle?= no 2025-02-24
23_sslutils_fix_error_message [PATCH] change error message for missing certificate
The old error message is quite similar to the openssl `failed to retrieve issuer certificate` and can mislead users to troubleshooting certificate stores.

The new message should be distinct enough to make it clear to users that this is not a problem raised by the underlying SSL implementation, but a problem inside monitoring-plugins.
=?UTF-8?q?Andre=20Kl=C3=A4rner?= <kandre@ak-online.be> no 2025-03-17
24_check_http_deprecation [PATCH] check_http: Adding deprecation text Jan Wagner <waja@cyconet.org> no 2025-04-19

All known versions for source package 'monitoring-plugins'

Links