Debian Patches

Status for flann/1.9.1+dfsg-9

Patch Description Author Forwarded Bugs Origin Last update
0001-Updated-fix-cmake-hdf5.patch Updated fix cmake hdf5 Leopold Palomo-Avellaneda <leo@alaxarxa.net> no 2016-07-15
0001-src-cpp-fix-cmake-3.11-build.patch [PATCH] src/cpp: fix cmake >= 3.11 build
CMake < 3.11 doesn't support add_library() without any source file
(i.e add_library(foo SHARED)). But flann CMake use a trick that use
an empty string "" as source list (i.e add_library(foo SHARED "")).
This look like a bug in CMake < 3.11.

With CMake >= 3.11, the new behaviour of add_library() break the
existing flann CMake code.

From CMake Changelog [1]:
"add_library() and add_executable() commands can now be called without
any sources and will not complain as long as sources are added later
via the target_sources() command."

are provided intentionally since the flann shared library is created by
linking with the flann_cpp_s static library with this line:

target_link_libraries(flann_cpp -Wl,-whole-archive flann_cpp_s -Wl,-no-whole-archive)

If you try to use "add_library(flann_cpp SHARED ${CPP_SOURCES})" (as it should
be normally done), the link fail due to already defined symbol.

They are building the shared version using the static library "to speedup the
build time" [3]

This issue is already reported upstream [2] with a proposed solution.

Upstream status: Pending

Fixes:
http://autobuild.buildroot.net/results/b2f/b2febfaf8c44ce477b3e4a5b9b976fd25e8d7454

[1] https://cmake.org/cmake/help/v3.11/release/3.11.html
[2] https://github.com/mariusmuja/flann/issues/369
[3] https://github.com/mariusmuja/flann/commit/0fd62b43be2fbb0b8d791ee36290791224dc030c
Romain Naour <romain.naour@gmail.com> no 2018-04-18
0003-Use-system-version-of-liblz4.patch Use system version of liblz4
Also make sure that flann_cpp is linked against LZ4.
Jochen Sprickerhof <git@jochen.sprickerhof.de> no 2018-10-14
0004-Add-empty-date-in-manual-to-make-build-reproducible.patch Add empty date in manual to make build reproducible Jochen Sprickerhof <git@jochen.sprickerhof.de> no 2018-10-14

All known versions for source package 'flann'

Links