Debian Patches

Status for mender-connect/2.1.0+ds1-4

Patch Description Author Forwarded Bugs Origin Last update
0001-Extend-test-sleeps-for-reliability.patch Extend test sleeps for reliability
The tests are even flaky in my local builds.
They seem to be more reliable with extra/extended sleep times in a few
places.
Lets also think about slower architectures where we don't want to have
tests time out.....
Andreas Henriksson <andreas@fatal.se> no 2022-12-06
0002-Fix-limits-test-user-name-mixup.patch Fix limits test user name mixup
currentUser is supposed to have the current uid's username, not
the descriptive field of the user (aka gecos).
Atleast that's what it gets compared against eventually.

The following two tests are affected and could sometimes give
false-positives (since there's an explicit check if the user name
is the empty string and then return true, which is true in some build
scenarios when gecos is empty) but could also fail when gecos contained
the actual users full name.

task-0: --- FAIL: TestPermit_UploadFile/file_exists_allowed_to_overwrite_owner_match (0.00s)

task-0: --- FAIL: TestPermit_DownloadFile/file_owner_match (0.00s)
Andreas Henriksson <andreas@fatal.se> yes 2023-01-09
0003-Fix-racing-connection-tests.patch Fix racing connection tests
The listening tcp port needs to be up before we connect
or the client will end up with "connection refused".

When listen is done in a (go) thread, there's no guarantee
the thread even gets to execute before the test moves on to
do the connect.

Insert a sleep after thread creation in tests that has
been seen to be flaky (on debian build infrastructure),
hopefully long enough that the thread doing the listening
gets a chance to run first.

The TestPortForwardHandlerSuccessfulConnection was reproduced
locally (reliably) and the change confirmed to fix the issue there.
The TestReconnect is an approximation that it's the same/similar
issue and hopefully the sleep will fix it.

Relevant build logs from debian infrastructure showing the problems:
https://buildd.debian.org/status/fetch.php?pkg=mender-connect&arch=ppc64el&ver=2.1.0%2Bds1-3&stamp=1673302707&raw=0
https://buildd.debian.org/status/fetch.php?pkg=mender-connect&arch=armel&ver=2.1.0%2Bds1-3&stamp=1673345986&raw=0
https://buildd.debian.org/status/fetch.php?pkg=mender-connect&arch=armhf&ver=2.1.0%2Bds1-3&stamp=1673322854&raw=0
Andreas Henriksson <andreas@fatal.se> no 2023-01-10

All known versions for source package 'mender-connect'

Links