Debian Patches

Status for otpw/1.5-2

Patch Description Author Forwarded Bugs Origin Last update
privacy.patch replace link to css file by local version to avoid privacy breach
===================================================================
Thorsten Alteholz <debian@alteholz.de> no
01-fix-pam-otpw-linking commit f084457ebcb657afba47c76f5d3e5880493cf7b8

Use `gcc' to link pam_otpw.so instead of `ld'.

Using `gcc' as a linking driver is the natural way to perform the
linking step as it will take care to add the necessary additional
libraries.

This solves the following issues:
- pam_otpw.so was not linked against the libc; while this is generally
not an issue, pam_otpw.so uses features of the libc and as a result it
should record it as a runtime dependency;
- pam_otpw.so did not work on some embedded architectures (ex: armv7l)
which do not implement in hardware some operations like modulo. In
such situation, pam_otpw.so must statically link against libgcc.a which
brings software emulation of these operations. Such implicit linking is
correctly performed when using gcc as a linking driver.

diff --git a/Makefile b/Makefile
index 9c82d86..e1c35aa 100644
Ludovic Stordeur <ludovic@funolang.net> no 2017-02-09
02-fix-pam-otpw-useless-deps commit c526ef75c9e287b9a457b9c190a7ab7e9825b61a

Remove useless dependencies of pam_otpw.so

pam_otpw.so does not use any symbols of libpam_misc.so nor libcrypt.so
and as a result it should not link against it.

diff --git a/Makefile b/Makefile
index e1c35aa..b2a3e79 100644
Ludovic Stordeur <ludovic@funolang.net> no 2017-02-09
03-fix-makefile-pamlib-variable commit b64ae53ebbbb5d21dff5c8268a28e045b50a8c81

Use `gcc' to guess the Target Triplet instead of hardcoding one.

This should help to provide a more portable PAMLIB variable computation.

===================================================================
Ludovic Stordeur <ludovic@funolang.net> no 2017-02-09
04-fix-signed-vs-unsigned-comparison commit 8fc6b3d5f01f6de2d517986330ab4c5896a81d64

Fix GCC warning: signed vs unsigned comparison.

The `struct passwd.pw_uid' is typed with `uid_t' which is defined as an
unsigned integer.

So we now define `otpw_autopseudouser_maxuid' as an `uid_t' as well.

As a result, the comparison of this variable against 0 at otpw.c:124
can be removed.

diff --git a/otpw.c b/otpw.c
index ba91558..6fc585b 100644
Ludovic Stordeur <ludovic@funolang.net> no 2017-02-16
hardening.patch allow hardening flags from debian/rules=================================================================== Thorsten Alteholz <debian@alteholz.de> no
spelling.patch fix spelling errors detected by lintian=================================================================== Thorsten Alteholz <debian@alteholz.de> no

All known versions for source package 'otpw'

Links