Debian Patches

Status for pinentry/1.1.0-4

Patch Description Author Forwarded Bugs Origin Last update
0001-avoid-self-describing-as-a-beta.patch avoid self-describing as a beta
Using autoreconf against the source as distributed in tarball form
invariably results in a package that thinks it's a "beta" package,
which produces the "THIS IS A DEVELOPMENT VERSION" warning string.

since we use dh_autoreconf, i need this patch to avoid producing
builds that announce themselves as DEVELOPMENT VERSIONs.

See discussion at:

http://lists.gnupg.org/pipermail/gnupg-devel/2014-November/029065.html
Daniel Kahn Gillmor <dkg@fifthhorseman.net> no 2015-05-13
0002-gtk2-When-X11-input-grabbing-fails-try-again-over-0..patch gtk2: When X11 input grabbing fails, try again over ~0.4 seconds.
* gtk+-2/pinentry-gtk-2.c (grab_keyboard): Delay 1 ms before retrying
keyboard grab, limit to about 0.2 seconds.
(grab_pointer): Delay 1 ms before retrying pointer_grab, limit to
about 0.2 seconds.

--

These changes were proposed by Vincent Bernat in
https://bugs.debian.org/851707#124
Vincent Bernat <bernat@debian.org> no 2017-02-06
0003-fltk-Fix-formatting-escapes.patch fltk: Fix formatting escapes.
* fltk/main.cxx (fltk_cmd_handler): Fix calls to fl_message()
and fl_choice() functions.
--

The fl_message and fl_choice functions expect a format string as
their first argument; passing the message directly might cause a
crash (or worse) if the message happens to contain formatting
escape chars.

(cherry picked from commit a60e4f8142159b3e2df10d8d725b9680be5b4616)
Daniel Kahn Gillmor <dkg@fifthhorseman.net> no 2019-02-07
0004-gnome3-Use-the-default-dbus-timeout-when-checking-fo.patch gnome3: Use the default dbus timeout when checking for screenlock
* gnome3/pinentry-gnome3.c (pe_gnome_screen_locked): use default dbus
timeout instead of 0ms.

--

At the moment, every single check to see if the screen is locked fails
immediately with a timeout, which is then silently ignored.

This is happening because the definition of the timeout argument is a
millisecond count, with -1 as the (unspecified) default, and G_MAXINT for no
timeout.

This means 0 times out immediately, and that leads to a complete inability for
pinentry-gnome3 to fallback to curses input when the screen is locked.

(Which then prevents a remote session from ever asking for a PIN, even when
the local session is locked.)

(cherry picked from commit 65d2c6d5911ab04b19f953153d01116198cc4cb8)
"Zephaniah E. Loss-Cutler-Hull" <zephaniah@gmail.com> no 2019-04-17
0005-gnome3-correctly-detect-when-no-GNOME-screenlock-exi.patch gnome3: correctly detect when no GNOME screenlock exists
* gnome3/pinentry-gnome3.c (pe_gnome_screen_locked): skip
G_IO_ERROR_IS_DIRECTORY responses, not G_IO_ERROR_TIMED_OUT responses
from dbus.

--

After the previous commit, testing demonstrates that the normal
response when no screenlock is running is G_IO_ERROR_IS_DIRECTORY, not
G_IO_ERROR_TIMED_OUT.

(cherry picked from commit f74c4673e6b60508012c14f7574dbc3215345210)
Daniel Kahn Gillmor <dkg@fifthhorseman.net> no 2019-04-17
0006-qt-Fix-use-of-dangling-pointer-in-QApplication.patch qt: Fix use of dangling pointer in QApplication
* qt/main.cpp (main): Use a new variable for argc that stays
valid.
--
The QApplication constructor takes argc as a reference and the referenced
integer has to stay alive for at least as long as the QApplication.

Based on a Patch from: Fabian Vogt <fvogt@suse.com>
Thanks!

(cherry picked from commit 0e2e53c8987d6f236aaef515eb005e8e86397fbc)
Andre Heinecke <aheinecke@gnupg.org> no 2019-07-25

All known versions for source package 'pinentry'

Links