| Patch | Description | Author | Forwarded | Bugs | Origin | Last update |
|---|---|---|---|---|---|---|
| 00-path-to-server-script.patch | Use Debian's ycmd package locations for ycmd. We neither have the third_party directory for vim-youcompleteme nor for ycmd, so we can't import them and we don't want to either. . This means we can drop lots and lots of complicated code as we know by virtue of dependencies where everything is and that it is good |
David Kalnischkies <donkult@debian.org> | not-needed | 2020-10-28 | ||
| 01-allow-tests-to-be-run.patch | Use Debian's ycmd package locations for ycmd in tests We neither have the third_party directory for vim-youcompleteme nor for ycmd, so we can't import them and we don't want to either. . The two python tests are removed as we have always Python installed in Debian due to dependencies and the tests can for some reason not override this properly. |
David Kalnischkies <donkult@debian.org> | not-needed | |||
| 02-allow-to-retry-failed-test-runs.patch | Allow retrying failed vim tests automatically The vim tests are somewhat sensitive to timing, so if the machine isn't the fastest or does other things concurrently it can happen that the timing in the tests fail to match reality. . Ideally the tests would not be sensitive to timing issues, but that is a bigger and more involved problem to solve for upstream. So as a tiny downstream we just cop out here and allow the tests to be retried a bunch of times likely hitting the 'PASS' jackpot in a retry. |
David Kalnischkies <donkult@debian.org> | no | |||
| 03-do-not-override-unset-ycmd-settings.patch | Load ycmd default settings from its default_settings.json Upstream prefers to keep the configuration in one place, but as Debian has ycmd and vim-youcompleteme in two different packages and can update them independently it makes more sense to not override the defaults ycmd has as that would require updating both packages then. . This is still the case as the configuration options are only documented here as they can only be changed sensible from here by the user, but it allows at least the package maintainer to change options in one place and only have the documentation lagging behind (or ahead) slightly. |
David Kalnischkies <donkult@debian.org> | invalid | 2020-10-28 | ||
| 04-do-not-require-semantic-highlighting.patch | Do not require a ycmd upgrade No need to entangle us too strongly for experimental features | David Kalnischkies <donkult@debian.org> | not-needed | |||
| 05-test-supports-different-hierarchy-order-on-s390x.patch | Support different order in type hierarchies test on s390x For some reason on s390x only the order of the type hierarchies is different in that it names D1 first instead of last like on the rest. . As this doesn't really matter we can adapt the test to accept both and stop worrying for now. In an ideal world we would not be this dependent on the order as any order seems fine, but we will see if that turns out to be an actual problem for future clang changes. . I might have been the first human in existence to have run vim-youcompleteme on a s390x machine and I might also be the last so upstreaming that seems overkill for now. |
David Kalnischkies <donkult@debian.org> | not-needed | |||
| 06-support-different-clangds-in-tests.patch | Support different clangd versions in tests Upstream always blesses and embeds a specific LLVM version and hence clangd release and adapts their tests accordingly. While we could do similar requiring a specific clangd version I prefer using whatever is the default in Debian currently, which means we are sometimes ahead or behind and usually both. . For upstream the changes are at best not-needed, but at times I take a shortcut and relax the tests which for upstream isn't appropriate, but for us it should be good enough for the time being. . An example being the CheckPopupPosition change (the only current one) as technically only one position is correct and changing it would be incorrect/a regression, but given the constraint is still very narrow I picked this solution for now. |
David Kalnischkies <donkult@debian.org> | not-needed | |||
| 07-support-different-ycmds-in-tests.patch | Support different ycmd versions in tests Similar to previous patch dealing with different clang (and related) versions this one deals with different versions of ycmd causing differences in the tests so that I can avoid lock-stepping the two even if in practice usually the newest of both will run together. . If its more than simple hard-to-observe/cosmetic changes upstream usually uses an increase in CORE_VERSION instead which we can follow. . For upstream the changes are at best not-needed, but at times I take a shortcut and relax the tests which for upstream isn't appropriate, but for us it should be good enough for the time being. |
David Kalnischkies <donkult@debian.org> | not-needed | |||
| 08-ignore-arch-specific-details-in-hover-test.patch | Ignore architecture-specific details in hover vim-test Offset and Padding are different on e.g. i386 vs. amd64, so we go from exact matching to manually comparing arrays of lines of text which we match individually against an expected pattern. For most lines, that will be a fixed string as before, but for the offending two we will accept any number in place of a fixed one. |
David Kalnischkies <donkult@debian.org> | no | |||
| 09-allow-tests-to-be-skipped.patch | Implement a simple interface to skip vim tests In this way I can skip certain tests in autopkgtest to run them later on individually if desired. . The patch is incomplete as it does handle only skipping entire tests while upstream allows running individual testcases inside a test file, so an upstreamable --skip should ideally support this as well beside that the patch as-is depends on the retry one at the moment althrough trivially. |
David Kalnischkies <donkult@debian.org> | no | |||
| 10-add-libclang-test.patch | Check that libclang-based completer offers fixit clangd is preferred and more featureful, but libclang is a decent fallback and as long as we built it, it should at least keep working. |
David Kalnischkies <donkult@debian.org> | not-needed | |||
| 11-add-ccls-test.patch | Check ccls support Support is Debian specific as upstream already has libclang and clangd for the cfamily and adding more is hard to do platform agnostic, while in Debian it is hardly one apt call way and hence easy to do. |
David Kalnischkies <donkult@debian.org> | not-needed | |||
| 12-add-gopls-test.patch | Check gopls works The test content itself is a bit pointless, but it can at least proof that go support isn't entirely broken. |
David Kalnischkies <donkult@debian.org> | not-needed | |||
| 13-add-fortran-test.patch | Adding a simple test for fortran completer This is Debian-specific as enabling the completer is a Debian-specific patch in ycmd. |
David Kalnischkies <donkult@debian.org> | not-needed |